-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/streamlink and live #659
base: main
Are you sure you want to change the base?
Feature/streamlink and live #659
Conversation
…e new trait ToQueryString. Now only shows FollowingStreaming (live users)
… instance upon joining a channel. Likewise for showing live versus all following channels
for more information, see https://pre-commit.ci
Beware that I've left a few things a bit of a mess. Wasn't sure how you'd want things organized / implemented so I left them as is. |
Config for what player to use and stream quality would be good |
Understandable. I've had a quick look over the PR, and it conflicts about my intuition for how this could be implemented. The following widget takes from the twitch API, so based on a config/state value the API call could probably just be switched out and the UI could be changed a little to show a tab/header based on if you're currently searching by who you're following and who's live. I see that you already have the logic for that, but I don't think this requires changes of higher level component structures. TLDR change following widget to do a different API call based on config/state value.
I like that idea. If you want to make a tracking issue for that, go ahead. |
I can't remember exactly, but Also, you probably want to checkout what I'm doing with spawning streamlink and holding onto that process handle, because I didn't really know what I was doing. |
I'll take a longer stare in the near future, thank you for the initial changes! |
Hey, sorry I haven't gotten around to this (IRL stuff). Hope to get a proper review going soon. |
Implements #658
See annotated code changes. I expect what I've done can be improved.